Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple version of singleton feature with featureUtility installFeature command #17319

Merged
merged 2 commits into from
May 28, 2021
Merged

Allow multiple version of singleton feature with featureUtility installFeature command #17319

merged 2 commits into from
May 28, 2021

Conversation

jjiwooLim
Copy link
Contributor

Fixes #17299

@jjiwooLim jjiwooLim added the release bug This bug is present in a released version of Open Liberty label May 26, 2021
@jjiwooLim jjiwooLim self-assigned this May 26, 2021
bensonlatibm
bensonlatibm requested changes May 27, 2021
View reviewed changes
Copy link
Contributor

@bensonlatibm bensonlatibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only need to update all copyright headers to include 2021

@jjiwooLim
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Mu2AML72Eeu5V8GZL3dwAw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

The build jjiwooLim-17319-20210527-0823
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Mu2AML72Eeu5V8GZL3dwAw
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_Mu2AML72Eeu5V8GZL3dwAw

@jjiwooLim
Copy link
Contributor Author

The build failed with wlp.lib.extract_fat failures which are unlrelated to these changes

@jjiwooLim
Copy link
Contributor Author

#libbybot

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

WARNING: This pull request contains binary files, which should be managed in a Maven repository.

  • 3 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 5 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

bensonlatibm
bensonlatibm approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@bensonlatibm bensonlatibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bensonlatibm
Copy link
Contributor

The wlp.lib.extract_fat failures are unlrelated to these changes. They will be fixed via
https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.workitem.viewWorkItem&id=276597

@jjiwooLim jjiwooLim merged commit bdac1fb into OpenLiberty:integration May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensonlatibm bensonlatibm bensonlatibm approved these changes

Assignees

@jjiwooLim jjiwooLim

Labels
CLA Signed release bug This bug is present in a released version of Open Liberty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple version of singleton feature with featureUtility installFeature command
3 participants
@jjiwooLim @LibbyBot @bensonlatibm